Add a better setup for copilot #6066
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds GitHub Copilot configuration to the Wasmer repository to help developers with code suggestions and ensure CI compliance. The changes provide setup instructions and a workflow to validate the development environment.
Changes:
- Added GitHub Copilot instructions document with coding standards and CI requirements
- Created a new workflow for validating Copilot setup steps with Rust toolchain, LLVM, and wasixcc installation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/copilot-instructions.md | Defines coding standards, best practices, and CI validation commands for GitHub Copilot to follow |
| .github/workflows/copilot-setup-steps.yml | Workflow that sets up the development environment with required dependencies and validates the setup works |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
| - name: Ensure the setup works | ||
| run: | | ||
| cargo fmt --check || true | ||
| RUSTFLAGS="-D dead-code -D nonstandard-style -D unused-imports -D unused-mut -D unused-variables -D unused-unsafe -D unreachable-patterns -D bad-style -D improper-ctypes -D unused-allocation -D unused-comparisons -D while-true -D unconditional-recursion -D bare-trait-objects -D function_item_references -D clippy::uninlined_format_args " cargo clippy --all --exclude wasmer-swift --locked --allow-dirty -- -D clippy::all || true |
There was a problem hiding this comment.
Is the || true intentional here?
There was a problem hiding this comment.
Well, kind of yes, so it does not fail to setup if there are formatting errors. However, considering that, running those commands here is quite useless. I'll remove them tomorrow.
|
Btw. is this PR somehow related to #5922? |
|
Yes, this fixes #5922 |
This PR adds copilot setup to give it access to
cargo fmt,wasixcc, our clang builds, clippy, and some other tools. This PR also adds copilot instructions that tell it to be diligent and to actually runcargo fmtandcargo clippy.